WPBP/WordPress-Plugin-Boilerplate-Powered

Introduce CI

Closed this issue · 12 comments

  • Fix Composer config #161
  • Set up PHPStan #163
  • Choose a Coding Standard #166
  • Enable CI #168

I mean CI for this repo, not CI for plugins made from this repo.

@Mte90 What CS would you follow in PHP code?
PSR-12, WPCS, Neutron, other?

Could you point me to a full-fledged plugin made from this boilerplate?
I'd set up PHPStan for all possible problems.

Mte90 commented

I am looking to the various pr, thanks!
Right now I am using this phpcs https://github.com/codeatcode/codeatcs that is downloaded by https://github.com/WPBP/generator but is replaceable during the boilerplate generation.

Mte90 commented

Do you think that is useful? right now that xml is downloaded by the generator and placed in the root of the plugin so anyone can customize it based on their needs.
If will do a package this require to create a new one etc...

Every PHPCS ruleset is distributed as a Composer package.

Composer even has a special package type for that: "type": "phpcodesniffer-standard",

Mte90 commented

I will do a package asap.

Thank you.

Mte90 commented

Seems yes because I got that
PHP CodeSniffer Config installed_paths set to ../../phpcompatibility/php-compatibility,../../phpcompatibility/phpcompatibility-paragonie,../../phpcompatibility/phpcompatibility-wp,../../phpcsstandards/phpcsdevcs,../../slevomat/coding-standard,../../wp-coding-standards/wpcs

Where is codeatcs??

Mte90 commented

You are right, checking the tool code require that the file is called ruleset so I will do a new release.