[Feature] Can we add assets/build/ to .gitignore?
Closed this issue · 13 comments
Is your feature request related to a problem? Please describe.
These are dynamic files; there is no reason to store them in Git. Primarily they will be generated automatically after npm install. Or they can be auto-refresh with npm run start.
Describe the solution you'd like
Add assets/build/ to .gitignore.
Describe alternatives you've considered
Add assets/build/ to .gitignore by myself.
Additional context
None.
There is already https://github.com/WPBP/WordPress-Plugin-Boilerplate-Powered/blob/master/.gitignore#L41
Maybe it isn't changed the plugin slug on the generator?
No with the generator the slug is changed, did you used the boilerplate with that?
I see what happened. I only commit the plugin contents.
Can we also ignore it without the plugin-name since the .gitignore file is inside the plugin?
I would also like to use Composer to install the plugin from a repository (e.g., when using Bedrock and packages). How can we do that?
I understand what is happening, the generator move the .gitignore so the path doens't works anymore.
I am fixing.
About composer to install the plugin in the past someone asked too but I never used bedrock or composer to install plugin.
Thank you for your hard work!
Can we remove composer.lock from .gitignore? - *.lock
I prefer to leave there, there is people that don't want to commit the lock.
Maybe I can add an option to the plugin generator to remove it.
That would be awesome. Thank you!
https://github.com/WPBP/WordPress-Plugin-Boilerplate-Powered/blob/master/.gitignore as I can see the composer.lock isn't there
*.lock will also ignore composer.lock.
Implemented in the generator :-)
I am not sure when I will do a new release of the boilerplate.
About composer to install the plugin in the past someone asked too but I never used bedrock or composer to install plugin.
Can I open a feature request in case someone wants this feature and is capable of implementing it?
Yeah sure, usually is just me working on this project so let's see.
Yeah sure, usually is just me working on this project so let's see.
There are so many WP developers, but very few are working on development tools.