WPP-Public/akqa-nz-silverstripe-versioneddataobjects

VersionedModelAdmin Class breaks compatibility with silverstripe-versioned-gridfield

Closed this issue · 9 comments

adrexia commented

We have a few projects that use this module in conjuction with Versioned gridfield (https://github.com/icecaster/silverstripe-versioned-gridfield). Unfortunately, as of this commit: 9df0bee
we are getting namespace errors when we try to update as VersionedModelAdmin exists in both dependencies.

stecman commented

Votes? I'd say 1, but throwing an alternative in for the sake of it:

  1. add a namespace to all classes and release as a new major version, or
  2. add a _manifest_exclude file in the code directory and use Composer's autoloading rather than SilverStripe's class manifest (would prevent the module being used without composer).

In the meantime, if you really had to make this work you could use a post-install-cmd/post-update-cmd in composer that removed the offending file.

stevie-mayhew commented

I'd vote for 1.

adrexia commented

1 sounds more robust.

camspiers commented

I vote 1 too.

glenn-bautista commented

I vote 1

tamelion commented

I like option 1.

Leapfrognz commented

Option 1

assertchris commented

Option 1

stecman commented

Released namspaces in 2.0.0. Thanks @assertchris!

  • 👍2