WPP-Public/akqa-nz-silverstripe-versioneddataobjects

Class 'SearchVariantVersioned' doesn't exist

Closed this issue · 2 comments

nedmas commented

So SearchVariantVersioned appears to be defined in silverstripe-fulltextsearch not framework or cms so by extending it in your SearchVariantVersionedDataObject class you have introduced a dependancy on silverstripe-fulltextsearch.

As far as I see it there are three possible solutions:

  1. Move SearchVariantVersionedDataObject to it's own package
  2. Declare silverstripe-fulltextsearch as a composer dependancy
  3. Check to see if SearchVariantVersioned exists and if it doesn't create a stub

I'm happy to do the work and submit a PR but wanted to see what your thoughts were first.

camspiers commented

Hey @nedmas thanks for spotting this, and for the detailed issue. I will get @stecman (he built this part) to have a look today as this is definitely a bug.

stecman commented

Thanks, @nedmas - looks like this snuck into the module while working on a project and I didn't clean it up later.