WTTJ/welcome-ui

Missing (peer)Dependencies

anucreative opened this issue · 2 comments

anucreative commented

[Design] For which Figma library?

None

For which component/foundations?

Others

Prioritization

Low 🏖️

Current Behavior

Several components are missing dependencies or peerDependencies:

lerna info Executing command in 68 packages: "depcheck"

@welcome-ui/checkbox: Missing dependencies
    @testing-library/react: ./tests/index.test.tsx
@welcome-ui/hint: Unused dependencies
    @welcome-ui/utils
@welcome-ui/tabs: Missing dependencies
    @testing-library/user-event: ./tests/index.test.tsx
@welcome-ui/button: Missing dependencies
    @testing-library/react: ./tests/index.test.tsx
    @welcome-ui/link: ./tests/index.test.tsx
    @welcome-ui/icons: ./tests/index.test.tsx
    @welcome-ui/icons.font: ./tests/index.test.tsx
@welcome-ui/core: Unused dependencies
    @welcome-ui/system
@welcome-ui/stack: Missing dependencies
    @testing-library/dom: ./tests/index.test.tsx
@welcome-ui/icons.font: Unused dependencies
    @welcome-ui/system
@welcome-ui/dropdown-menu: Missing dependencies
    @testing-library/react-hooks: ./tests/index.test.tsx
    @testing-library/user-event: ./tests/index.test.tsx
@welcome-ui/swiper: Missing dependencies
    @testing-library/user-event: ./tests/index.test.tsx
@welcome-ui/files: Missing dependencies
    react: ./src/index.ts
@welcome-ui/accordion: Missing dependencies
    @testing-library/react: ./tests/index.test.tsx
    @welcome-ui/box: ./src/styles.ts
@welcome-ui/pagination: Missing dependencies
    @testing-library/react: ./tests/index.test.tsx
    @testing-library/react-hooks: ./tests/index.test.tsx
@welcome-ui/tag: Missing dependencies
    @welcome-ui/icon: ./src/styles.ts
@welcome-ui/popover: Missing dependencies
    @testing-library/react: ./tests/hover.test.tsx
@welcome-ui/markdown-editor: Missing dependencies
    @testing-library/react: ./tests/index.test.tsx
    @testing-library/user-event: ./tests/index.test.tsx
    codemirror: ./src/utils.ts
@welcome-ui/drawer: Missing dependencies
    @testing-library/react: ./tests/index.test.tsx
@welcome-ui/modal: Unused devDependencies
    @types/body-scroll-lock
@welcome-ui/modal: Missing dependencies
    @testing-library/react: ./tests/index.test.tsx
@welcome-ui/file-drop: Unused dependencies
    @welcome-ui/button-group
@welcome-ui/radio: Missing dependencies
    @testing-library/react: ./tests/index.test.tsx
@welcome-ui/toast: Unused dependencies
    @welcome-ui/clear-button
    @welcome-ui/utils
    @welcome-ui/variant-icon
@welcome-ui/toast: Missing dependencies
    @welcome-ui/close-button: ./src/Growl.tsx
    @welcome-ui/text: ./src/index.tsx
@welcome-ui/picker: Unused dependencies
    @welcome-ui/utils
@welcome-ui/field: Unused dependencies
    @welcome-ui/field-group
@welcome-ui/field: Missing dependencies
    @testing-library/user-event: ./tests/index.test.tsx
    @testing-library/dom: ./tests/index.test.tsx
@welcome-ui/radio-group: Missing dependencies
    @testing-library/react: ./tests/index.test.tsx
@welcome-ui/radio-tab: Unused devDependencies
    @welcome-ui/radio
    @welcome-ui/radio-group
@welcome-ui/input-text: Missing dependencies
    @testing-library/react: ./tests/index.test.tsx
@welcome-ui/search: Unused dependencies
    @welcome-ui/tag
@welcome-ui/search: Missing dependencies
    @testing-library/react: ./tests/index.test.tsx
    @testing-library/user-event: ./tests/index.test.tsx
    @welcome-ui/shape: ./tests/index.test.tsx
@welcome-ui/select: Missing dependencies
    @testing-library/react: ./tests/index.test.tsx
    @testing-library/user-event: ./tests/index.test.tsx
    @welcome-ui/icon: ./src/styles.ts
@welcome-ui/password-input: Missing dependencies
    @testing-library/react: ./tests/index.test.tsx
@welcome-ui/emoji-picker: Unused dependencies
    @welcome-ui/stack
    @welcome-ui/variant-icon
@welcome-ui/emoji-picker: Missing dependencies
    @testing-library/react: ./tests/index.test.tsx
    @welcome-ui/emoji: ./src/List.tsx
    @ariakit/react: ./src/index.tsx
@welcome-ui/slider: Unused dependencies
    @welcome-ui/utils
@welcome-ui/slider: Missing dependencies
    @welcome-ui/box: ./src/Range.tsx
    @welcome-ui/hint: ./src/Range.tsx
@welcome-ui/date-time-picker-common: Missing dependencies
    date-fns: ./src/CustomHeader.tsx
    @welcome-ui/icon: ./src/styles.ts
@welcome-ui/time-picker: Unused dependencies
    @welcome-ui/utils
@welcome-ui/date-picker: Unused dependencies
    @welcome-ui/utils
@welcome-ui/date-time-picker: Unused dependencies
    @types/react-datepicker
    @welcome-ui/button
    @welcome-ui/clear-button
    @welcome-ui/field
    @welcome-ui/icons
    @welcome-ui/select
    react-datepicker
@welcome-ui/date-time-picker: Missing dependencies
    @testing-library/react: ./tests/index.test.tsx
    @testing-library/user-event: ./tests/index.test.tsx

Expected Behavior

These components should have the correct dependencies

Screenshots / Videos

No response

[Tech] Welcome UI Version

No response

[Tech] Browser

No response

[Tech] Operating System

MacOS

anucreative commented

Be good to add a lint rule in to check all components have the correct dependencies / peerDependencies

Have added pre-push hook and Circle workflow item to check dependencies

anucreative commented

Note: This is low-priority but will help fix some issues with federated modules when sharing common libs between the host and remotes, so if we can merge this "quickly" that would be great. 🙏🏼