Waikato/moa

Time measurement for AdaptiveRandomForest in parallel mode

Jwata opened this issue · 2 comments

Jwata commented

DoTask measures CPU time of TaskThread.

moa/moa/src/main/java/moa/DoTask.java

Line 225 in f8b4d48

+ StringUtils.secondsToDHMSString(taskThread.getCPUSecondsElapsed()));

Since I'm not expert at Java, I may be wrong.
But when running AdaptiveRandomForest learner with multi threads (= with numberOfJobs option), I suspect time spent on the AdaptiveRandomForest threads isn't included in the TaskThread time in DoTask.

moa/moa/src/main/java/moa/classifiers/meta/AdaptiveRandomForest.java

Line 160 in f8b4d48

this.executor = Executors.newFixedThreadPool(numberOfJobs);

Is my understanding correct?
If so, is it ok to use wall clock time for measuring ARF runtime?

hmgomes commented

Hi @Jwata
Your understanding is correct. You should measure the wall clock time in this case.

Jwata commented

@hmgomes
Thank you for your confirmation. Will measure wall clock time.