bug: Correction in the size of cards in the company page.

Question

bug: Correction in the size of cards in the company page.

Closed this issue 2 years ago · 6 comments

Asmi-1 commented 2 years ago

Description

There is a card which is smaller in size in comparison to the other cards in the company page.

Answer 1 · 2022-10-08T10:53:52.000Z

I'd like to take on this. Please assign.

Answer 2 · 2022-10-08T10:56:32.000Z

Hey @Asmi-1 I would like to work on this issue. Please assign me

Answer 3 · 2022-10-08T11:15:36.000Z

@Asmi-1 actually all the cards are somewhat not equal in size. They are simple images. Simple CSS properties will fix these. give them height: 100%, aspect-ratio:1, object-fit: cover I think this will be enough

Answer 4 · 2022-10-08T11:42:48.000Z

@Asmi-1 actually all the cards are somewhat not equal in size. They are simple images. Simple CSS properties will fix these. give them height: 100%, aspect-ratio:1, object-fit: cover I think this will be enough

Yes, I have examined the code and also thought of doing same as you suggested. Thank you for your valuable solution.

Answer 5 · 2022-10-08T12:04:13.000Z

@Asmi-1 actually all the cards are somewhat not equal in size. They are simple images. Simple CSS properties will fix these. give them height: 100%, aspect-ratio:1, object-fit: cover I think this will be enough

Yes, I have examined the code and also thought of doing same as you suggested. Thank you for your valuable solution.

I have fixed the bug by simply changing gallery0's size as that was the only one that has a different size than the others. please check: this PR

Answer 6 · 2022-10-08T14:01:22.000Z

@Asmi-1 actually all the cards are somewhat not equal in size. They are simple images. Simple CSS properties will fix these. give them height: 100%, aspect-ratio:1, object-fit: cover I think this will be enough

Yes, I have examined the code and also thought of doing same as you suggested. Thank you for your valuable solution.

I have fixed the bug by simply changing gallery0's size as that was the only one that has a different size than the others. please check: this PR

@Eddayavuz I think you have chosen the longer way to fix this, instead we can fix it simply by adding just two lines of height and width properties in the code.