WalkingPal/walking-pal-web

bug: need accessibility improvements

Closed this issue · 5 comments

satnaing commented

Description

The accessibility of this site can be improved. For example, there is

  • the lack of lang attribute in html element
  • link icons don't have alt text / title
  • headings are not correctly ordered (sequentially-descending order)
  • Color contrast issues
  • Empty links
  • etc etc
  • make sure to do these accessibility improvements in global components too that are present in the page you are working on (for example ScrollToTop button or Header component)

Make a draft PR first. Your PR's build will be deployed.
You can use https://wave.webaim.org/report#/<PUT-YOUR-PR's-PREVIEW-BUILD's-URL-HERE> to do all your accessibility analysis. Do analysisi on the latest Preview build only.

Checkout the file changes and PR review comments in this PR to get more clear view on what changes you need to do.

There are 5 pages. We need to do this in all 5 pages.

Progress

⚠Contributors who are interested, please tell beforehand that which page you are going to start working on. This will avoid clashes (possibility of 2 people working on the same page).

ashuvssut commented

headings are not correctly ordered (sequentially-descending order)

We have never thought of this before. We have not used headings in sequential order. We just followed what was heading was given in the figma design board. Make changes such that it the UI designs remain same only.

We can implement sequential descending order by using component prop in the Typography component

ashuvssut commented

@satnaing, assigned you Home Page.

Asmi-1 commented

I want work on About page

ashuvssut commented

@satnaing, assigned you company page. Make sure cover all global components used in company page too

senali-d commented

@ashuvssut I would love to work on FAQs Page

  • 👍1