WalletConnect/WalletConnectSwiftV2

WalletConnectURI(deeplinkUri: URL) doesn't take into account percent encoding

simonmcl opened this issue · 3 comments

Describe the bug
WalletConnectURI(deeplinkUri: URL) will return nil if its percent encoded. The constructor only checks for "wc:". if the colon is percent encoded, the check fails and it returns nil

SDK Version

  • Client: Swift
  • Version 1.9.9

To Reproduce
Try to use a percent encoded URL

Expected behavior
SDK should check if its percent encoded and handle the situation if so

What is the use case? Where are you getting percent encoded string?

@flypaper0 a web based dApp sent it to my app like that. I assume some frontend framework/library/utility etc is doing this automatically. Likely to happen in the wild with some many technologies around

will be included in the next release