WaviestBalloon/ApplejuiceCLI

file not found error, stack overflow or seg fault after a few seconds

Closed this issue · 6 comments

Issue

No matter how I try to launch Roblox player or studio with Applejuice a stack overflow or seg fault is triggered.

To reproduce

Try and launch something with Applejuice.

Terminal output

The top 3 lines are spammed to the point I can't see anything else. I tried piping it to a file to get a full log but it never would.

[ ! ] Assuming a asset was missing; falling back to no icon...
[ ! ] Failed to create notification, raw: ''
Error: No such file or directory (os error 2)
[ ! ] Assuming a asset was missing; falling back to no icon...
[ ! ] Failed to create notification, raw: ''
Error: No such file or directory (os error 2)
[ ! ] Assuming a asset was missing; falling back to no icon...
[ ! ] Failed to create notification, raw: ''
Error: No such file or directory (os error 2)
[ ! ] Assuming a asset was missing; falling back to no icon...
[ ! ] Failed to create notification, raw: ''
Error: No such file or directory (os error 2)
[ ! ] Assuming a asset was missing; falling back to no icon...
[ ! ] Failed to create notification, raw: ''
Error: No such file or directory (os error 2)
[ ! ] Assuming a asset was missing; falling back to no icon...
[ ! ] Failed to create notification, raw: ''
Error: No such file or directory (os error 2)
[ ! ] Assuming a asset was missing; falling back to no icon...

thread 'main' has overflowed its stack
fatal runtime error: stack overflow
Aborted (core dumped)

Other details

I use POP!_OS. I know it has a curse that makes software not work but I'm hoping that's not the case here.

Launching Roblox through Steam works perfectly fine.

Looking more into it, the create_notification function recurses into itself infinity creating this issue.

Someone else had this issue but I have yet to get around to implementing it, this was because of issues during asset downloading for icons.
Thank you so much for your very detailed Issue, I'll take a look at your PR right now!

One small question, do you have libnotify installed? As the function interfaces with notify-send command which you may not have installed already.

Your PR #14 was merged into the testing branch, again, thank you. I just want to know whether libnotify is installed and if that fixes the infinite loop.

Error: No such file or directory (os error 2) is caused by notify-send when a icon location is invalid but it is also caused if the command is not found.

libnotify was not installed, and installing it does fix the issue. I might work on a better solution than the one I already did (like detecting if notify-send is actually there).

libnotify was not installed, and installing it does fix the issue. I might work on a better solution than the one I already did (like detecting if notify-send is actually there).

Alright! If you do open another PR, I'll be more than happy to review it ASAP :D

Update: Since #18, we now depend on notify-rust crate