[switcher] Plugin always turned off in GUI
nwg-piotr opened this issue · 14 comments
Even if I check the Switcher check box (or "Use This Plugin" in plugin setting), it remains turned off, as if settings had not been saved. Adding switcher to plugins = in wayfire.ini works as expected.
The only thing wcm does to save settings is write the config file. If it's not doing this, it's a wcm bug. I'd check permissions on the config file.
Other settings are being saved correctly.
Works fine for me here, not sure what could be going wrong.
Not a big issue, but worth of diagnosing. I'm on a fresh install from the master branch.
[edit] I preserved the old wayfire.ini file.
When you enable Switcher in wcm, it doesn't write 'switcher' to the plugin list in the config file? And you're not confusing Fast Switcher with Switcher, right?
It might clear things up if you grep -in switch ~/.config/wayfire.ini before and after enabling/disabling the checkbox in wcm. Also, presumably you are using the git version of wcm?
I've just enabled Switcher in wcm, and opened the wayfire.ini file:
I see that it has fast- in the plugin list which seems odd. Are you using wayfire -c or --config option to specify a config file by chance?
I'm not. I also have no idea what the fast- may mean. My config file derives from the very first one.
Ah, it is a wcm bug. I can reproduce it now. It is because fast-switcher is enabled, then when switcher is disabled it looks for the first instance of 'switcher' to eliminate from the plugin string. This leaves fast- so it needs to be a bit smarter. Will send a patch.
I expected something like this.
@nwg-piotr This should fix it.
It works, still the check box isn't being refreshed on startup. I mean: does not reflect the actual state.
There are other commits that should fix it, just make sure you have latest git.
Confirmed.