Crash in `plugin_enabled()`

Question

Crash in `plugin_enabled()`

ammen99 opened this issue 5 years ago · 8 comments

At main.cpp:81, plugins[pos - 1] is accessed, but pos can be 0 so this triggers a crash.

Answer 1 · 2019-10-01T18:03:37.000Z

@ammen99 Is there a way to reproduce this?

Answer 2 · 2019-10-01T18:05:29.000Z

I am not sure why it happens here. It didn't happen before, and now it crashes every time, even before I pulled latest changes.

Answer 3 · 2019-10-01T18:06:19.000Z

@ammen99 But what action is crashing it? Just starting it?

Answer 4 · 2019-10-01T18:06:48.000Z

Yes, this is a crash on start up.

Answer 5 · 2019-10-01T18:07:50.000Z

Looking at the code, I think it is quite expected that pos can be 0. I think the reason why this started to crash is that I removed viewport_impl from my plugin list.

Answer 6 · 2019-10-01T18:14:34.000Z

@ammen99 Can you show the output of wcm and the plugins line from your config file?

Answer 7 · 2019-10-01T18:31:48.000Z

Presumably the first plugin loaded matched the first plugin in the list and this caused the crash. It didn't here for whatever reason but obviously needed this check. Thanks.

Answer 8 · 2019-10-01T18:35:52.000Z

thanks for fixing this!