WaylonWalker/markata

"hatch run tui" seems to be broken.

Closed this issue · 4 comments

"hatch run tui" seems to be broken.

Issue produced on windows 10 as shows below.

`PS C:\Users\user\tmp\markata> pip show markata
Name: markata
Version: 0.5.2
Summary: Static site generator plugins all the way down.
Home-page:
Author:
Author-email: Waylon Walker waylon@waylonwalker.com, waylon@markata.dev
License: Copyright (c) 2012-2022 Waylon Walker

    Permission is hereby granted, free of charge, to any person obtaining
    a copy of this software and associated documentation files (the
    "Software"), to deal in the Software without restriction, including
    without limitation the rights to use, copy, modify, merge, publish,
    distribute, sublicense, and/or sell copies of the Software, and to
    permit persons to whom the Software is furnished to do so, subject to
    the following conditions:

    The above copyright notice and this permission notice shall be
    included in all copies or substantial portions of the Software.

    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
    EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
    MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
    NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
    LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
    OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
    WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

Location: c:\users\user\appdata\local\programs\python\python39\lib\site-packages
Requires: anyconfig, beautifulsoup4, checksumdir, cookiecutter, copier, deepmerge, diskcache, feedgen, jinja2, more-itertools, pathspec, pillow, pluggy, pymdown-extensions, python-frontmatter, python-slugify, pytz, rich, textual, toml, typer
Required-by:
PS C:\Users\user\tmp\markata> pip show textual
Name: textual
Version: 0.3.0
Summary: Modern Text User Interface framework
Home-page: https://github.com/Textualize/textual
Author: Will McGugan
Author-email: will@textualize.io
License: MIT
Location: c:\users\user\appdata\local\programs\python\python39\lib\site-packages
Requires: importlib-metadata, nanoid, rich, typing-extensions
Required-by: markata
PS C:\Users\user\tmp\markata> hatch.exe run tui
╭─────────────────────────────── Traceback (most recent call last) ────────────────────────────────╮
│ C:\Users\user\AppData\Local\hatch\env\virtual\testing-markata\amOosx_h\testing-markata\lib\sit │
│ e-packages\markata\plugins\tui.py:55 in tui │
│ │
│ 52 def cli(app, markata): │
│ 53 │ @app.command() │
│ 54 │ def tui(): │
│ ❱ 55 │ │ MarkataApp.run(log="textual.log") │
│ 56 │
│ 57 │
│ 58 if name == "main": │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
TypeError: run() got an unexpected keyword argument 'log'`

Thanks for raising, this is from the late changes in textual. I'll have a release out soon to address this, followed by an update to use the new textual.

For right now you can run this

hatch shell
# or however you want to activate a venv

pip install textual<0.2.0

Thank you for the great work you do! I will give this a try tomorrow.

Fixed in #107, its live on develop branch and in 0.6.0.dev13, get the pre-releease with this command.

pip install markata --pre

#128 pins textual properly. Had some issues with 0.6.0 that I wasn't comfortable going live with yet.