WeTransfer/WeTransfer-iOS-CI

Verify re-run tests that succeed after failure are not blocking PRs

AvdLee opened this issue · 2 comments

A test can be re-run after failure and succeeding:
image

Though, it looks like PRs still get blocked by a test failure being reported. We should look into this.

It's best to reproduce this locally by writing a test that fails 50/50

Example log:
apps_6bee37a5a2a41cdb_47ac49f1-faed-438b-a7e7-b1bb900d7b0a-full.txt.zip

Would be great if we can (still) leave a Danger warning indicating that a test failed the first/second time, but succeeded the next time, to not hide the fact that tests may be indeterministic.

Would be great if we can (still) leave a Danger warning indicating that a test failed the first/second time, but succeeded the next time, to not hide the fact that tests may be indeterministic.

Just for completeness, I implemented that here: #109