[Danger] Replace custom rules with SwiftLint versions
AvdLee opened this issue · 3 comments
To ensure the same outcome locally in Xcode as when CI completes. Currently, we only see issues once CI succeeded which is a lose of time.
It's not possible to create a "proper" final_class rule, which would check if a class is actually subclassed, as custom rules can only be built using a regex :( But since that's basically the same as our current implementation does, that should be okay I guess.
It's not possible to create a "proper" final_class rule, which would check if a class is actually subclassed, as custom rules can only be built using a regex :( But since that's basically the same as our current implementation does, that should be okay I guess.
I agree, that would be better than our current rule since we would get back feedback at build time instead of PR time
Closing this since I guess this is done!