[CI] Add an option to automatically merge PRs on green

Question

[CI] Add an option to automatically merge PRs on green

AvdLee opened this issue 3 years ago · 8 comments

Automatically merging PRs would speed up quite some cases

Answer 1 · 2021-11-02T16:46:58.000Z

@BasThomas would love to get your ideas for this! Any experience with solutions?

Answer 2 · 2021-11-02T17:41:13.000Z

Also nice: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request

Answer 3 · 2021-11-02T18:37:20.000Z

Haven't implemented something like this in the past. But let me take a look at it; especially the built-in GitHub automerge.

Answer 4 · 2021-11-03T10:44:11.000Z

This is fixed by enabling auto merge on our repositories.

Answer 5 · 2021-11-04T12:50:19.000Z

Reopening since auto-merge is also merging for red PRs, which is not good. It should really only merge when CI is green!

Answer 6 · 2021-11-04T12:53:13.000Z

Oh noes! 🙈

Answer 7 · 2021-11-05T08:41:29.000Z

It seems to be fixed by setting restrictions towards merging, e.g. Danger and Bitrise need to succeed.
This is now enabled:

The downside is that manual merging isn't possible either when CI failed. Though, we really don't want to auto-merge when checks fail. Let's see whether these restrictions really become a problem.

Answer 8 · 2021-11-05T12:54:52.000Z

Closing for now, lets reopen if we need to revisit our implementation.