bad code is BAD

[jandrieu]

I forced a crash by removing the closing quote on a console.log (using the latest default.md works great to reproduce this). When I run it, the dev console gets

Uncaught SyntaxError: Invalid or unexpected token
at Object.run (satyrnicon.js:41)
at HTMLElement.onclick (app.html:1)
And the div got an ellipsis it seemed. "...."

That seemed reasonable, although we should catch the exception, it seemed ok.

But then I fixed the typo and ran the code again, and the app fell over:

satyrnicon.js:31 Uncaught RangeError: Maximum call stack size exceeded
at console.log [as oldLog] (satyrnicon.js:31)
at console.log [as oldLog] (satyrnicon.js:33)
at console.log [as oldLog] (satyrnicon.js:33)
at console.log [as oldLog] (satyrnicon.js:33)
at console.log [as oldLog] (satyrnicon.js:33)
at console.log [as oldLog] (satyrnicon.js:33)
at console.log [as oldLog] (satyrnicon.js:33)
at console.log [as oldLog] (satyrnicon.js:33)
at console.log [as oldLog] (satyrnicon.js:33)
at console.log [as oldLog] (satyrnicon.js:33)

This happens every time I run the now corrected code.

[jandrieu]

FWIW, reloading the file works fine (restores the context to a viable one). So the separation between main and rendering helps a lot, but we should handle this explicitly.

[ewelton]

Yes - this is just from the lazy way I captured console output. It will not be relevant when we switch to using a subprocess.

…

On 3/19/19 3:40 PM, Joe Andrieu wrote: FWIW, reloading the file works fine (restores the context to a viable one). So the separation between main and rendering helps a lot, but we should handle this explicitly. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#25 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA7ps1pzk-pglUtdos4rreUHXzuApD67ks5vYKJ6gaJpZM4b7jj4>.

[Deleted user]

This issue was moved by jandrieu to satyrnjs/satyrn#19.