Add Icon to Bundle, Render in Application

[wip-abramson]

This is an issue in electron-builder

See #40 for details,

[jandrieu]

In package.json, in the build.win/mac/linux sections, we can specify an icon.

"win": {
      "target": "zip",
      "icon": "logos/favicon/Favicon.ico"
    },
    "linux": {
      "target": "tar.gz",
      "icon": "logos/favicon/Favicon.ico"
    },
    "mac": {
      "target": "dmg",
      "icon": "logos/favicon/Favicon.ico"
    }

However, that fails on Windows because of a escape problem. We've deleted it from the package.json for now.

[HarounAns]

hey, did you ever figure out a work around? I'm getting the same error labeled "Unable to set icon image type is not icon for 'C'" for electron builder on windows. Did you come up with a solution to this problem?

[jandrieu]

I did not. Somewhere in the code, the path is being constructed poorly. I'm just not sure where.

[Deleted user]

This issue was moved by jandrieu to satyrnjs/satyrn#12.