WhatPumpkin/Sburb-Legacy

Just disable sounds if Audio is not supported

Closed this issue · 3 comments

Let them play the game in silence. No reason to break the whole thing, especially when some people just want the text-meats.

Just comment out the test. Audio loading already checks compatibility before trying to load the files, so it shouldn't break anything assuming calling play(), pause() and loop() on an empty audio element doesn't cause issues.

Probably not worth re-factoring all the audio code to avoid running at all if there is no audio support.

No yeah, that's what I meant. But someone needs to go through and make sure that the system doesn't vomit from null sounds, and references to sounds in the actions being absent. I'm pretty sure there's already a fair amount of checks for that just because we turned off sounds a lot in early development, but the stuff has shifted around a lot.

@illuminatedwax probably knows best at this point where it could go wrong.