Microsoft Edge bug?, Television?

Question

Microsoft Edge bug?, Television?

Closed this issue 7 years ago · 4 comments

Hi! I'm using the plugin in an Ionic project, everything seems to be working fine.

Works on Android, iOS, browsers like Chrome, Firefox, Safari.

All good, except Microsoft Edge 16.

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36 Edge/16.16299

It crashes when I instantiate the WhichBrowser object.

Debugging in Microsoft Edge debugger, Shows that it crashes in a line (if statement)

here's the internal file: Television.js

/* Generic model information */

  static detectGenericTelevisionModels(ua) {
    let match;
    if ((match = /\(([^,(]+),\s*([^,(]+),\s*(?:[Ww]ired|[Ww]ireless)\)/u.exec(ua))) {               //  <----- IT CRASHES HERE
      const vendorName = Manufacturers.identify(Constants.deviceType.TELEVISION, match[1]);
      const modelName = match[2].trim();

There it is, the if statement.

Is this bug? What am I doing wrong?

Answer 1 · 2018-05-21T09:08:45.000Z

Hi! First of all I wrote the library with Node in mind, so many Browsers will not work. You aren’t having any problem because you use all last or almost last versions. No coming to the problem: thanks for the detail report, can you add here a full stracktrace of the error please? Thanks, Simone

…

Hi! I'm using the plugin in an Ionic project, everything seems to be working fine. Works on Android, iOS, browsers like Chrome, Firefox, Safari. All good, except Microsoft Edge 16. It crashes when I instantiate the WhichBrowser object. Debugging in Microsoft Edge debugger, Shows that it crashes in a line (if statement) here's the file: Television.js /* Generic model information */ static detectGenericTelevisionModels(ua) { let match; if ((match = /\(([^,(]+),\s*([^,(]+),\s*(?:[Ww]ired|[Ww]ireless)\)/u.exec(ua))) { // <----- IT CRASHES HERE const vendorName = Manufacturers.identify(Constants.deviceType.TELEVISION, match[1]); const modelName = match[2].trim(); There it is, the if statement. Is this bug? What am I doing wrong? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Answer 2 · 2018-05-21T15:41:49.000Z

Oh I see, then I think I have to use the php backend, but my server doesn't support php neither node.

It's firebase, I will find the solution to my problem thanks for the answer.....

Answer 3 · 2018-05-21T16:20:38.000Z

Hey, take a look at https://cloud.google.com/functions/ for running node functions and consume them from Firebase! Let me know if you need further support for the issue.

…

On 21 May 2018, 16:41 +0100, Pedro ***@***.***>, wrote: Oh I see, then I think I have to use the php backend, but my server doesn't support php neither node. It's firebase, I will find the solution to my problem thanks for the answer..... — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Answer 4 · 2018-05-23T12:48:28.000Z

Thanks for the help! I'll take a look at it.