WhichBrowser/Parser-PHP

`PlayStation` needs to be standardized + add PlayStation 5

summercms opened this issue · 0 comments

Some code lines say PlayStation and other code lines say Playstation for the results.

Note I'm talking about the S in the word Station.

  • PlayStation - Correct result.

  • Playstation - Incorrect result.

Example of correct code line:

if (preg_match('/Silk-Accelerated/u', $ua) || !preg_match('/PlayStation/u', $ua)) {

Example of incorrect code line:

'model' => 'Playstation 2',

The correct result should be this:

'model' => 'PlayStation 2', 

Issues

This is causing regex problems in the repo when testing.

Files to be updated

https://github.com/WhichBrowser/Parser-PHP/blob/master/src/Analyser/Header/Useragent/Device/Gaming.php
https://github.com/WhichBrowser/Parser-PHP/blob/master/tests/unit/Model/DeviceTest.php
https://github.com/WhichBrowser/Parser-PHP/blob/master/src/Analyser/Corrections.php
https://github.com/WhichBrowser/Parser-PHP/blob/master/src/Analyser/Header/Useragent/Browser.php
https://github.com/WhichBrowser/Parser-PHP/blob/master/data/applications-browsers.php

Testing to be updated

https://github.com/WhichBrowser/Parser-PHP/blob/master/tests/data/gaming/sony.yaml

PlayStation 5 UA

Mozilla/5.0 (PlayStation 5/SmartTV) AppleWebKit/605.1.15 (KHTML, like Gecko)

Mozilla/5.0 (PlayStation 5 3.03/SmartTV) AppleWebKit/605.1.15 (KHTML, like Gecko)