William-Yeh/ansible-fluentd

Support for ubuntu 18.40

Opened this issue · 0 comments

When trying to use this role on Ubuntu 18.04 (bionic) I get an error about python-software-properties:

(item=['python-software-properties', 'apt-transport-https']) => {"ansible_loop_var": "item", "changed": false, "item": ["python-software-properties", "apt-transport-https"], "msg": "No package matching 'python-software-properties' is available"}

Looking at the package index for xenial and bionic it appears that python-software-properties has been renamed to python3-software-properties. But it also seems that they both have software-properties-common which appears to provide the same thing?

Should we change the role to install software-properties-common instead? Or move the dependency list to a variable that can be overwritten depending on ubuntu version?

Happy to do a PR if you let me know the preferred way to go.