Willster419/RelhaxModpack

Add a check when doing database update for media

Closed this issue · 5 comments

Arkhorse commented

When performing a DB update, have the toolbox parse the media for all packages, and determine if they are valid. This should help us ensure all media works.

Maybe you could make it so it keeps a list of master domains, and it parses those first? Any domain that doesnt work, would also prevent all media from working.

Willster419 commented

This is a good idea

Willster419 commented

I'm thinking this can be a simple check to:

  • Load the database
  • For each SelectablePackage, For each Media where type is image or audio
  • Attempt to download it.

The question becomes what to do if it fails. For starters, we'd want to log it of course. But do we want to additionally remove the offending medias? Or just log it? Or allow for a user update?

Thoughts?

Arkhorse commented

Well, if it was in the editor, rather than the toolbox, it could just open the offending package to the media tab, and if possible, flash the offending entry. Sadly I dont know of a way to test the webpage one...

Also, can the media combobox have a default to image?

Willster419 commented

I think this is done with 8a0bfdc

Check it out:
image