Buffer copy without checking size of input
jishanshaikh4 opened this issue · 1 comments
jishanshaikh4 commented
Does not check for buffer overflows.
LABEL: Bug
SEVERITY: Major
SOLUTION: Use sprintf_s, snprintf, or vsnprintf.
COMMON WEAKNESS ENUMERATION INDEX: CWE-120
Instances found in the GitHub repository:
- src\kms.c:281
- src\output.c:168
ChlorideCull commented
The kms.c file is clean, the function allocates the string and limits the size of the number it's formatting into it.
While output.c does not follow best practices, there is no bug in it today.