WordPress/openverse-api

Run black before flake8 in pre-commit

sarayourfriend opened this issue · 0 comments

Problem

We run flake8 before black. This means flake8 will spit out a bunch of errors that black is about to fix anyway, meaning the first run of a lint that includes non-fixable changes will be muddied and hard to wade through due to no longer valid changes. Worse, line numbers could be changing as well if black is correcting issues in modules that also have other flake8 problems.

Description

Flip the order and run flake8 only after black has run so that flake8 does not waste time (and cause confusion) reporting errors that black is about to fix anyway.

Implementation

  • 🙋 I would be interested in implementing this feature.