WordPress/openverse-catalog

Move tests into subfolders

AetherUnbound opened this issue · 0 comments

Current Situation

Currently, all of our tests live alongside the DAGs/provider scripts.

Example:

$ ls openverse_catalog/dags/provider_api_scripts/
brooklyn_museum.py
cleveland_museum_of_art.py
europeana.py
finnish_museums.py
flickr.py
healthcheck.py
jamendo.py
metropolitan_museum_of_art.py
museum_victoria.py
nypl.py
phylopic.py
raw_pixel.py
science_museum.py
smithsonian.py
staten_museum.py
stocksnap.py
test_brooklyn_museum.py
test_cleveland_museum_of_art.py
test_europeana.py
test_finnish_museums.py
test_flickr.py
test_jamendo.py
test_metropolitan_museum_of_art.py
test_museum_victoria.py
test_nypl.py
test_phylopic.py
test_raw_pixel.py
test_science_museum.py
test_smithsonian.py
test_staten_museum.py
test_stocksnap.py
test_walters_art_museum.py
test_wikimedia_commons.py
Thingiverse.py
walters_art_museum.py
wikimedia_commons.py

Suggested Improvement

To make navigating the codebase easier, we could move the tests either to a subdirectory within a given folder (e.g. openverse_catalog/dags/provider_api_scripts/tests) or a shared, top-level folder that mirrors the directory structure of the project (e.g. tests/dags/provider_api_scripts/).

Benefit

This creates a clearer separation between production code and tests.

Additional context

This applies to all submodules within the project.

Implementation

  • 🙋 I would be interested in implementing this feature.