WordPress/wordpress.org

Accessibility: Plugin single links and buttons missing hover states

Closed this issue · 5 comments

On the plugin single page (Gutenberg plugin test page), the buttons and links are all missing hover states.

On hover, text links should have the underline removed.

On hover, buttons need a design change that either contrasts with the default state or is other wise visually distinct (switching from solid to underline or adding an icon, for example).

the buttons and links are all missing hover states.

It looks like these are not using the correct button styles — but if the old button classes are replaced with the block classes wp-block-button__link in the markup, that should help.

On hover, text links should have the underline removed.

Yeah, this is a bug.

On hover, buttons need a design change that either contrasts with the default state or is other wise visually distinct (switching from solid to underline or adding an icon, for example).

We recently had a discussion about button styles, and from my research and understanding of the guidelines, the fact that the mouse cursor changes from default to pointer is enough of a change — although by default, the blue buttons should get slightly darker on hover. https://wordpress.org/download/ shows these buttons the way they're supposed to work.

@WordPress/meta-design Do these need to be buttons? Can they not just be links? I don't know if we have an agreed-upon scenario where a button is preferred.

Before After
Screenshot 2024-04-22 at 10 22 52 AM Screenshot 2024-04-22 at 10 22 48 AM

Edit

The ratings section above doesn't include a button.

Screenshot 2024-04-22 at 10 25 59 AM

Links look good 👍 👍

Links look good 👍 👍

Agreed, links look good and removing the buttons also increases the prominence of the Download and Live Preview (for those plugins that have it) buttons.

I made underlined as the default for the theme and updated button states. If any components are missing links or inconsistent, let's open up new tickets for those specific changes.

Thanks!