Block Editor Handbook: Improve it on Github links are broken
Closed this issue · 4 comments
All links I've spot checked in the Block Editor handbook have broken links.
The hrefs are appended with [article_edit_link].
For example: https://developer.wordpress.org/block-editor/
The link goes to : https://developer.wordpress.org/block-editor/[article_edit_link]
Note: requires Gutenberg 18.1+ to reproduce
Transferring issue to correct repo
I'm unable to duplicate.
All the links are correct for me, and curl https://developer.wordpress.org/block-editor/ | grep 'article_edit_link' shows nothing.
Note, that that is the shortcode being used though, which suggests shortcodes weren't applying (Which you cal also see from the [last_updated] shortcode being present in the image)
Sorry, slow to update the ticket. This happened earlier today when we unpinned Gutenberg and switched to trunk. With trunk the hook we are using to process shortcodes in patterns stopped firing (see WordPress/gutenberg#60349), so we have rolled back. We still need a long term solution.
Looks like this is resolved and this issue is in the wrong place so I'll close this ticket.
It looks like shortcodes do work as normal block content, but not in attributes. Depending on the outcome of WordPress/wporg-parent-2021#136, we might want to reopen this to switch out for shortcodes in core blocks, or maybe block bindings.
For example, these shortcodes work, but you can see the last_updated heading isn't rendered.
<!-- wp:paragraph -->
<p>[article_edit_link]</p>
<!-- /wp:paragraph -->
<!-- wp:button {"className":"is-small"} -->
<div class="wp-block-button is-small"><a href="[article_edit_link]" class="wp-block-button__link wp-element-button"><?php esc_html_e( 'Edit', 'wporg' ); ?></a></div>
<!-- /wp:button -->
