ANNOYING BUG : It sends way too much notifications

Question

ANNOYING BUG : It sends way too much notifications

Closed this issue 6 years ago · 9 comments

I had 1 unread message, it sent approximately 15 notifications at the same time!

Firefox 65.0, macOS 10.11.6 El Capitan

Answer 1 · 2019-02-09T15:31:36.000Z

@WorldLanguages

Answer 2 · 2019-02-09T16:48:53.000Z

Wow that's weird!
I don't know what is causing it tho, take a look at this line: https://github.com/WorldLanguages/ScratchNotifier/blob/master/notifier.js#L115
It only sends the notification if msgCount > oldMsgCount, and oldMsgCount is the value of the global variable msgCount before checking the message count again.
Unless Firefox for some reason decided to trigger checkMainMessages() many times at once for some reason, I have no idea what can cause this.

Answer 3 · 2019-02-09T17:16:16.000Z

It didn't did after. My computer was sleeping, maybe it has impacted it ?

Answer 4 · 2019-02-09T17:50:27.000Z

@WorldLanguages

Answer 5 · 2019-02-09T18:23:49.000Z

@locness3 That's probably it. I'll make a fix soon.

Answer 6 · 2019-02-09T19:22:28.000Z

This should be fixed with commit e66cfc1
checkMainMessages() now can only run if it hasn't been called in the last 5 seconds (and if that call was ran too).
@locness3 Would be helpful if you told me if this happens with alt accounts too. I don't know why it wouldn't, tho.

Answer 7 · 2019-02-10T07:46:10.000Z

Huh, none of my alt accounts recieves messaages, lol

Answer 8 · 2019-02-10T22:13:14.000Z

@locness3 Fixed, stupid bug because of something I modified the day of the release... Make sure to have the bell enabled for that alt of course, if you want to test this

Answer 9 · 2019-02-11T15:05:50.000Z

You should unassign you so