WowLegacyCore/HermesProxy

Chat emote target

Opened this issue · 2 comments

Describe the bug
When using /kiss or any other emote while targeting player/npc won't register.
"You blow kiss into a wind"

Game Server
Cmangos 2.4.3

Hermes Proxy Version
Last

0blu commented

Related to

[PacketHandler(Opcode.SMSG_TEXT_EMOTE)]
void HandleTextEmote(WorldPacket packet)
{
STextEmote emote = new STextEmote();
emote.SourceGUID = packet.ReadGuid().To128(GetSession().GameState);
emote.SourceAccountGUID = GetSession().GetGameAccountGuidForPlayer(emote.SourceGUID);
emote.EmoteID = packet.ReadInt32();
emote.SoundIndex = packet.ReadInt32();
uint nameLength = packet.ReadUInt32();
string targetName = packet.ReadString(nameLength);
WowGuid128 targetGuid = GetSession().GameState.GetPlayerGuidByName(targetName);
emote.TargetGUID = targetGuid != null ? targetGuid : WowGuid128.Empty;
SendPacketToClient(emote);
}

When I remember correctly we cannot send the exact npc id or something

tried it in 2.4.3 cmangos and targeting player worked