Port OSGi launcher back to this project
pavelhoral opened this issue · 2 comments
Right now the launcher component is in forgerock-commons-old project. AFAIK this project is only used by the IDM so it would be easier to port it here and maintain it as a part of this project instead of wrensec-commons.
Also the version we have (i.e. the one in forgerock-commons-old) is a bit rusted and can be upgraded (i.e. by using https://docs.oracle.com/javase/7/docs/technotes/guides/io/fsp/zipfilesystemprovider.html with glob matching) and extended with a few unit tests (I can see at least one bug just by looking at the source code of property interpolation).
I have looked into this and it makes sense to drop launcher-zip submodule and use commons-daemon artifact instead.
Not sure how to handle launcher submodule yet (whether we should include it as a new openidm-launcher submodule or just merge it with openidm-system). I guess the main question is whether we really need to have a separate bootstrap jar (launcher.jar) or whether we can leave that to Felix.
Done. Launcher has been ported as openidm-launcher submodule.