Wubbadub/ClubHub

Implement Linting and Testing frameworks

Closed this issue · 8 comments

bndnio commented

Feature Name
Dev Linting and Testing tools

Description
Integrating linting and testing tools allow developers to ensure their code is neat and functional

Requires

  • React, Webpack, and Babel to be implemented

Subtask Breakdown

  • Determine testing framework
  • Implement testing framework
  • Implement ESLint
  • Set up ESLint rules

Due
Milestone 2

Time Estimation:
6hrs.

bndnio commented

Finished Linter and rules, need to tackle testing now

hwkr commented

@BrendonEarl how does the linter run?

bndnio commented

ESlint collects the rules in .eslint.js and runs through them in the webpack build process (as a pre-loader)

hwkr commented

Okay, it doesn't seem to be linting .jsx files

hwkr commented

Can we set up pre commit linting? I think this might work.

bndnio commented

Looks like it, only thing is whether that'll prevent a commit if any error or warning occurs or only if an error occurs

hwkr commented

I think we should prevent commits with warnings too.
Side note: you should fix the warnings in the samples or update the linting spec.

hwkr commented

Tests are lame. Lolz.