Not fully removing newlines with async/defer in script-tag

Question

Not fully removing newlines with async/defer in script-tag

lifeofguenter opened this issue 7 years ago · 4 comments

    <script async defer
    src="https://maps.googleapis.com/maps/api/js?key=YOUR_API_KEY&callback=initMap">
    </script>

(via: https://google-developers.appspot.com/maps/documentation/javascript/adding-a-google-map)

Answer 1 · 2017-10-08T20:51:53.000Z

Interesting, I'll have a look at it. Thanks for reporting 👍

Answer 2 · 2017-12-26T20:30:16.000Z

Hey sorry for the late reply, been busy with https://github.com/reactphp/http/releases/tag/v0.8.0 the past few months. I'll be adding an edge case test for this later today/tomorrow ensuring this works as intended. Thank you for reporting, I'll keep you posted 👍

Answer 3 · 2017-12-27T15:43:07.000Z

After digging into this, this isn't a bug because the new line takes the same amount of space as a space. As demonstrated by the test in #30 and the fix in c89bd37

Answer 4 · 2017-12-28T19:58:59.000Z

Just tagged 1.3.0 with this in it 🎉 .