X-Sharp/XSharpPublic

Duplicate DEFINEs and functions in the runtime, SDK and RP2

cpyrgas opened this issue · 0 comments

https://www.xsharp.eu/forum/topic?p=28951#p28951

There are plenty duplicate DEFINEs in the runtime, SDK and RP2, causing "Warning XS9043 'DEFINE_xxx' is ambiguous." that cannot be "fixed". It's probably a good idea to clean those up for X# 3.0.

  • MAKELANGID()

Runtime:
FUNCTION MAKELANGID( p AS WORD, s AS WORD ) AS WORD
RETURN (WORD) ( ( s << 10 ) | p )

SDK (WinNT.prg of Win32APILibrary):
FUNCTION MAKELANGID(p, s) AS WORD
EnforceNumeric(@p)
EnforceNumeric(@s)
RETURN ( _OR( (WORD(_CAST, S) << 10), WORD(P)))

  • DEFINEs in RP2 and SDK:

DEFINE DT_SINGLELINE := 0x00000020
DEFINE CF_EFFECTS := 0x00000100L

and many more like those, we will need to search and make a full list when we look into it of course