Incompatibility with View Locked Skills
Iridar opened this issue · 0 comments
The mod in question: https://steamcommunity.com/sharedfiles/filedetails/?id=1130817270
This mod is redundant with CPS, as the same functionality can be enabled through MCM. The mod appears to implement a UISL that uses copypasted promotion screen code to redraw ability icons.
Using the mod breaks the functionality of ability tagging, and - as mentioned - its redundant. But not entirely. By default the mod keeps Training Center perks hidden, and adds a button and a checkbox to the promotion screen.
The button can be used to take one look at the Training Center abilities, while the checkbox can be used to toggle this status permanently.
I think the correct way to proceed would be to allow these mods to coexist in some way.
I propose the following:
- If CPS Show Unreached Perks is enabled, the View Locked Skills' UISL is killed so that CPS' ability tagging can function. CPS Show Unreached Perks trumps the View Locked Skills' keeping training center abilities hidden anyway.
- If CPS Show Unreached Perks is disabled, the View Locked Skills UISL is allowed to live and do its thing. However, it implements its own "on ability clicked" functions, so this may once again interfere with controllers. I don't think this is an issue enough to flag the mod as hands down incompatible with CPS, but worthy of noting in workshop description.