X2CommunityCore/xcom2-launcher

AML may crash if there are more than 50 missing dependencies

Opened this issue · 0 comments

Steam batch requests are limited to 50 entities. ModList.LoadNotInstalledDependencies() does not consider this and causes an unhandled exception, if there are more than 50 missing dependencies.

AML version: 1.6.0-alpha

Sentry GUID: deb34fd0-5a69-43aa-af0c-72675905710d
Message: Max allowed number of identifiers is 50.

Stack: 
   at XCOM2Launcher.Steam.Workshop.GetDetailsAsync (System.Collections.Generic.List`1[T] identifiers, System.Boolean getFullDescription) [0x00046] in <945f4166d96c4a07a68fb71ffce5a119>:0 
  at XCOM2Launcher.Mod.ModList.LoadNotInstalledDependencies (System.Collections.Generic.List`1[T] requiredModIds) [0x0010e] in <945f4166d96c4a07a68fb71ffce5a119>:0 
  at XCOM2Launcher.Mod.ModList+<>c__DisplayClass32_0.<GetRequiredMods>b__2 () [0x0006d] in <945f4166d96c4a07a68fb71ffce5a119>:0 
  at XCOM2Launcher.Mod.ModList.GetRequiredMods (XCOM2Launcher.Mod.ModEntry mod, System.Boolean substituteDuplicates, System.Boolean skipIgnoredDependencies) [0x0016a] in <945f4166d96c4a07a68fb71ffce5a119>:0 
  at XCOM2Launcher.Mod.ModList.GetDependentMods (XCOM2Launcher.Mod.ModEntry mod, System.Boolean compareModId) [0x0002b] in <945f4166d96c4a07a68fb71ffce5a119>:0 
  at XCOM2Launcher.Forms.MainForm.DeleteMods (System.Collections.Generic.List`1[T] mods, System.Boolean keepEntries) [0x00034] in <945f4166d96c4a07a68fb71ffce5a119>:0 
  at XCOM2Launcher.Forms.MainForm.ConfirmDeleteMods (System.Collections.Generic.List`1[T] mods) [0x0005f] in <945f4166d96c4a07a68fb71ffce5a119>:0 
  at XCOM2Launcher.Forms.MainForm+<>c__DisplayClass102_0.<CreateModListContextMenu>b__14 (System.Object <p0>, System.EventArgs <p1>) [0x00000] in <945f4166d96c4a07a68fb71ffce5a119>:0