Warning about missing choice label when choice has an image label
lognaturel opened this issue · 2 comments
Software and hardware versions
pyxform v2.0.0
Problem description
Warning about missing choice label when choice has an image label
Steps to reproduce the problem
- Convert a form with a choice list that only has image labels (no text labels) such as this one
- Notice the warnings:
On the choices sheet there is a option with no label. [list_name : images-only]
On the choices sheet there is a option with no label. [list_name : images-only]
Expected behavior
If choices in the list have images, there should be no warning. This may not be compatible with some of the new approach to warnings that we've taken so they may need to be reconsidered.
Other information
Things you tried, stack traces, related issues, suggestions on how to fix it...
If choices in the list have images, there should be no warning.
@lognaturel The warning that this comes from, which is a check for a choice name and label value, has been in the code base since 2012. On the XLSForm.org and docs.getodk.org, the label column is described as being one of 3 mandatory choices columns. Are we saying now that the label is (conditionally?) optional? Are any media OK in place of a label - or just images?
This may not be compatible with some of the new approach to warnings that we've taken so they may need to be reconsidered.
Sorry but what is this referring to?
Confirmed that this is old behavior. I thought it was related to changes to language warnings but it's not.