[Bug] Account referred to as not having signing access during SignIn request
Opened this issue · 4 comments
WillXUMM commented
Customer reported and Koen tested and confirmed.
- Import a new card in Xumm, then press Activate your account
- Press Get XRP
- Select XOORS
- Go through process. At "Identity verification"
- Press Continue to verify your account
You receive a message similar to this:
where the r-address is the r-address of the card you are trying to activate.
WietseWind commented
This is a bug for sure, I think signing access is being judged based on the availability of an activated account on the XRPL, which the account isn't, at this stage. Which shouldn't matter if the private key is available for the card and it's a pseudo transaction.
So:
- Signing access checks on ledger to see if you have actual signing access, e.g. if the master isn't disabled, or if e.g. the regular key is present
- If the account is not activated this can't be checked
If it is indeed the above, a fix would be: - If the account isn't activated but the secret to the account is natively present OR if it is a Tangem card: proceed
Which makes me think...
- @WillXUMM @KoenPaas Is this Tangem card specific, or is the Tangem card not the factor, and does this happen with any unactivated account? Depending on the kind of bug this could even apply to normal (unactivated) accounts. Although I think it may check for key and Tangem card has no key = Tangem specific.
KoenPaas commented
It’s all accounts not tangem specific.
WietseWind commented
Good, then it's as I explained or close to that, let's fix this in 2.6.0 @N3TC4T
Thanks for the digging!
WietseWind commented