XanderJC/scalable-birl

td error

Closed this issue · 1 comments

Hi there, I guess you missed the discount factor while computing the TD error:
https://github.com/XanderJC/scalable-birl/blob/main/sbirl/models.py#L189

I found that you are not using a discount factor, respectively gamma equals 1.0