Code no longer compiles with MSVC

Question

Code no longer compiles with MSVC

srcejon opened this issue 2 years ago · 6 comments

With the introduction of the complex data type, aptdec no longer compiles with MSVC, which is a shame, as the latest code can't be included in SDRangel

It's possible to write a little abstraction layer, so complex types can be used both with gcc/clang/MSVC, see here as an example:

https://github.com/srcejon/codec2/blob/windows-freedv/src/compiler.h

Would you be open to a patch that used something along these lines?

Answer 1 · 2022-09-20T18:03:18.000Z

~~https://learn.microsoft.com/en-us/cpp/c-runtime-library/complex-math-support?view=msvc-170 MSVC seems to have its own complex library, just different to POSIX, can you confirm?~~

EDIT: I have seen the link you have sent I will get on this right away

Answer 2 · 2022-09-20T18:15:39.000Z

MSVC seems to implement all the POSIX complex functions and the I constant so in theory this should work

Answer 3 · 2022-09-21T07:11:27.000Z

Thanks. It's not necessary to add zenith back in, I can remove that SDRangel. It's the complex in the hilbert_transform that's the main problem.

Answer 4 · 2022-09-29T10:12:00.000Z

This should be fixed, can you check?

Answer 5 · 2022-09-29T10:14:11.000Z

It compiles, thanks. Will try integrating it a little later on.

Answer 6 · 2022-09-30T15:43:39.000Z

Seems to work fine on Linux and Windows. Thanks.