Get Invoices paging with IDs
Closed this issue · 6 comments
SDK you're using (please complete the following information):
- Version 4.23.0
Describe the bug
As per the developer documentation when paging for invoices each page will contain up to 100 invoices. However, when paging using IDs query parameter the maximum number of IDs that we can pass into this query parameter is 52. This limits us to 52 invoices per request instead of 100 invoices per request.
We suspect this is a "max character limit per query parameter" set on your gateway where 53 IDs in the IDs query parameter exceeds this limit. This limitation makes us hit our rate limits quicker than expected.
Endpoint being called (IDs removed as the URL is very long with 53 IDs)
GET https://api.xero.com/api.xro/2.0/Invoices?IDs=61548c60-b5ff-460c-acba-7963b9879adc,[53 invoice IDs]&page=1
To Reproduce
Using an HTTP client create a request to the /Invoices endpoint. Set page query parameter to = 1. Set IDs query parameter = 53 valid invoices IDs
Expected behavior
We expect the API to return 100 invoices per page when being passed 100 invoice IDs in the IDs query parameter
Screenshots
Using 53 invoices IDs API returns 404 (even though these IDs do exist)
Using 52 invoices IDs API returns 52 invoices
Hi @lancedfr, thanks for reporting this. I have transferred the issue over to our Open API Spec since the issue is happening at the API level and not specific to the Java SDK.
Hi @lancedfr, since this restriction is due to the overall character length of the request url you could provide the InvoiceNumber instead of the InvoiceId. InvoiceNumbers are typically shorter than InvoiceIds which are a GUID (36 characters).
There is a bit about this in the Developer Centre docs
Retrieving a filtered set of resources
The number of parameters is only limited by the maximum url length. To ensure you receive a timely response from the API, we recommend you look to retrieve in a batch of 40.
https://developer.xero.com/documentation/api/accounting/requests-and-responses#retrieving-a-filtered-set-of-resources
Hi @rdemarco-xero Thanks for this suggestion. We have updated our solution to retrieve invoices by InvoiceNumber instead of GUID. This still reaches the character length of the request parameter. We have been debugging the Xero JDK and found that the resolved URL being invoked is
As you can see InvoiceNumbers= is being repeated.
When running the below HTTP GET command (after removing the repeated InvoiceNumbers=) we manage to get all 100 invoices by number.
When running the below HTTP GET command (which is what the Xero JDK URL resolves to) we do not get all 100 invoices by number. Instead we get Response code: 404 (Not Found); Time: 826ms (826 ms); Content length: 47 bytes (47 B)
We still think this is an issue that should be resolved. Thanks @RettBehrens for the recommendation to fetch 40 invoices at a time, this still reaches the URL length limit for us (as our invoices numbers can be up to 9 chars long) because the Xero JDK makes the URL unnecessarily too long by duplicating InvoiceNumbers= in the URL.
When reviewing the java doc for the UriBuilder (the class the Xero JDK uses to build the URL) we can see the queryParam(String name, Object... values) method states "If multiple values are supplied the parameter will be added once per value.". This causes the duplicating of InvoiceNumbers= in the URL.
I managed to update the com.xero.api.client.AccountingApi class to use String.join(",", invoiceNumbers) to join the list of strings to a comma separated string (Which is what the API expects for InvoiceNumbers).
if (invoiceNumbers != null) {
String key = "InvoiceNumbers";
Object value = invoiceNumbers;
if (value instanceof Collection) {
uriBuilder = uriBuilder.queryParam(key, String.join(",", invoiceNumbers));
} else if (value instanceof Object[]) {
uriBuilder = uriBuilder.queryParam(key, (Object[]) value);
} else {
uriBuilder = uriBuilder.queryParam(key, value);
}
}
This works because one comma separated string is being passed into queryParam method rather than multiple values. When testing this the resolved URL is now shorter and all 100 invoices are returned.
I believe the com.xero.api.client.AccountingApi class is generated from a template and my fix won't work as is. I'm happy to implement this fix; I'm just not sure where your templates reside for me to fix.