Xiao-MoMi/Custom-Fishing

[Feature Request] Add support for Paper's AsyncChat

Opened this issue · 2 comments

Hello,
Can you add the support for the Paper AsyncChatEvent and/or AsyncChatDecorateEvent in the configuration of your plugin please?
Because you're currently using an old listener: org.bukkit.event.player.AsyncPlayerChatEvent.

Example for a new configuration:

# Use Paper's async Chat Event
use-async-chat: true/false

Thank you so much if you add this! :)

This might take more resources because we can only get component from paper event. And before parsing it we have to convert it shaded-component and then call methods like
https://github.com/Xiao-MoMi/Custom-Nameplates/blob/main/paper/src/main/java/net/momirealms/customnameplates/paper/mechanic/font/WidthManagerImpl.java#L918
One more question, why do you need the paper event

This might take more resources because we can only get component from paper event. And before parsing it we have to convert it shaded-component and then call methods like https://github.com/Xiao-MoMi/Custom-Nameplates/blob/main/paper/src/main/java/net/momirealms/customnameplates/paper/mechanic/font/WidthManagerImpl.java#L918 One more question, why do you need the paper event

Hello,
Yes, I understand;
And why am I asking this? Because one of the plugins I use strongly recommends the use of this event to allow better compatibility. You're not the only plugin I've made this suggestion to, I've made it to a few others too!