Feedback thread for day1/board_io
cramsay opened this issue · 2 comments
cramsay commented
Feedback thread for day1/board_io
jogomojo commented
- is the bash stuff necessary? could this be more confusing to someone who has never dealt with a programming language before?
- when running the flashing led cell, it might be worth mentioning that they won't have control of the notebook while the loop is running.
- absolutely not into using zip
- might be worth explaining a bit more about loops in general. maybe this could be in notebook 1. Just something that prints out the numbers 0-9 so they get a sense of what
for led_num in range(board.buttons.length)
means. - might want to turn off all the leds again before the 'reacting to button presses' section.
cramsay commented
See PR #12 for the changes based on this. Main notes are:
-
I agree that some of the bash examples looked frightening, so I've removed them all except the hostname cell. My reasoning is:
- I wanted to demonstrate that the code really is running on the board and this is awkward to do via Python before explaining LED I/O
- More importantly, the
!
bash calls are used in some of the later notebooks forapt install
ing things and here is a nice place to tee that up.
-
"absolutely not into using zip" - Don't want to concede any FP ground but I think you've made the right call...
Thanks for looking through this!