Feedback thread for day2/1_basic_io
cramsay opened this issue · 2 comments
cramsay commented
Feedback thread for day2/1_basic_io
jogomojo commented
Part 1
General
Some really nice concepts in here. I particularly like using the switches to stop the program. Here's a few pointers:
- this is just a style thing, but: there's no need to have a new markdown cell for each paragraph. markdown will format this all for you in one cell.
- probably best to have a diagram of an LED. here's a public domain one i found on wikipedia
- still missing images throughout the notebook
- i think certain concepts need to be explained a little deeper. things like loops and blinking leds were covered in Day 1 notebooks but it wouldn't hurt to reiterate these concepts.
- make sure to use the
backticksin markdown to emphasise variable names
Some grammatical notes:
- " If you have dealt with basic I/O before bear with me as some of this will be review and there will be some simplifications made" - this is a super long sentence
- "The second is from to the LED to the GND pin on the PYNQ board"
- "Let's get more complicated. We also can set the num" ???
Part 2
General
very cool notebook. lot's of code for them to copy/paste
- some pictures still missing
- some general spelling mistakes (best to use the spellchecker) top answer on this thread shows how to install it
- maybe need to explain what functions are in more detail