Update FINN version in `get_finn.sh`
zzzDavid opened this issue · 1 comments
zzzDavid commented
Hi,
It seems that the current get_finn.sh
script uses an older commit:
finn-examples/build/get-finn.sh
Lines 30 to 33 in 7123fa5
This commit point has this dependency issue where importing finn can cause:
from sigtools import _signatures, _util File "/opt/conda/lib/python3.8/site-packages/sigtools/_signatures.py", line 83 , in <module> @attr.define(eq=False)
AttributeError: module 'attr' has no attribute 'define'
I found that the fix is added by:
Xilinx/finn#644
Updating to the latest commits in finn fixed this issue. I think it would be good to update the get_finn.sh
commit point.
mmrahorovic commented
Hi @zzzDavid !
Great catch. The v0.0.6 FINN-examples release points to the latest FINN release (v0.9). Please give it a try, this should resolve your issue as well.
If you're running into any other issues, please let me know!