Xotabu4/jasmine-protractor-matchers

Clean up code. Refactor code duplicates.

Xotabu4 opened this issue · 3 comments

Xotabu4 commented
  • - Use .map() as dataprovider for .it() in tests?
  • - Cleanup code duplicates
  • - Extract type assertion to function
  • - Configure to run tests for node 4, 5, 6
  • - Extract params handling to function
  • - TypeScript?
Xotabu4 commented

192303f

Extracted type assertion

Xotabu4 commented

Reduced code duplicate - e022dd2

Xotabu4 commented

Reduced code duplicate - 679ec8b

Still need some solution for parsing message and timeout. But i think can be fixed in 1.1.0