How about implementing WordPress Code Standards?

Question

How about implementing WordPress Code Standards?

Closed this issue a year ago · 4 comments

Running PHPCS with WPCS over code warns about code (or security) practices and of course makes repository compliant with WordPress coding rules/standards.

It is not that I especially like rules 😁 , but in addition to complying to standard they make code searching easier.

ddur commented a year ago

Thanks

Answer 1 · 2023-05-01T09:31:40.000Z

Edit: Oops, I was looking at the wrong repository. Disregard this comment. PHPCS has not been implemented yet.

Answer 2 · 2023-05-01T11:06:41.000Z

Edit: Oops, I was looking at the wrong repository. Disregard this comment. PHPCS has not been implemented yet.

Hi Yahnis.

Would you accept PR with your PHP code reformatted to comply with WordPress Coding Standards?
PHPCS is included and slightly modified in WPCS.

Answer 3 · 2023-05-01T11:45:06.000Z

No need, I went through the PHPCS reports for this repository now, and fixed/silenced most things.

There are still warnings/errors in the external dependencies (excluded via phpcs.xml), but I'm not sure it's worth fixing those. You would probably have to rewrite the metadata parser entirely to make it compliant.