Yan78/webduino

Add support for the HTTP PUT and DELETE verbs

Closed this issue · 7 comments

GoogleCodeExporter commented 
What steps will reproduce the problem?
1. Send either a PUT or DELETE request to the server
2. Try to figure out what kind of request it was
3. It will be reported as WebServer::INVALID

What is the expected output? What do you see instead?

The request type should be set to either WebServer::PUT or WebServer::DELETE 
instead of WebServer::INVALID


What version of the product are you using? On what operating system?

1.4.1 on Windows


Please provide any additional information below.

This can be easily fixed in WebServer::getRequest(). The result would be the 
the library would allow to build truly RESTful services.

Original issue reported on code.google.com by mark_lan...@gmx.net on 2 Nov 2010 at 3:37

GoogleCodeExporter commented 
Sounds like a good idea.

Original comment by ben.combee on 2 Nov 2010 at 2:12

  • Changed state: Accepted
GoogleCodeExporter commented

Original comment by ben.combee on 3 Nov 2010 at 12:57

  • Added labels: Priority-High
  • Removed labels: Priority-Medium
GoogleCodeExporter commented 
Here is a patch addressing this issue. I also added support of the recently 
standardized PATCH method.

Original comment by mark_lan...@gmx.net on 9 Jun 2011 at 3:35

Attachments:

GoogleCodeExporter commented 
Change with PUT and DELETE going into GitHub.  From reading PATCH RFC, I think 
that's harder to support, so I'm leaving it out.

Original comment by ben.combee on 9 Jan 2012 at 4:41

  • Changed state: Fixed
GoogleCodeExporter commented 
OK, I've create a pull request for this as well as for issue 12.

Original comment by mark_lan...@gmx.net on 9 Jan 2012 at 6:56

GoogleCodeExporter commented 
Btw. Why do you think PATCH is harder to support?

Original comment by mark_lan...@gmx.net on 9 Jan 2012 at 10:49

GoogleCodeExporter commented 
I got confused reading the PATCH RFC. I thought you had to support the OPTIONS 
method and specifying server configuration, but it's just a "can" section so 
it's optional.  I'll add it too.

Original comment by ben.combee on 9 Jan 2012 at 12:41