Pytorch

Question

Pytorch

FilipAndersson245 opened this issue 4 years ago · 7 comments

FilipAndersson245 commented 4 years ago

This project looks cool, will you add PyTorch support in the future?

Answer 1 · 2021-01-17T16:04:15.000Z

Yep, I already started writing one.

Answer 2 · 2021-01-17T21:58:00.000Z

https://github.com/YanaiEliyahu/AdasOptimizer/blob/master/adasopt_pytorch.py

In my own testing it works OK.
How does it work for you?

Answer 3 · 2021-01-18T12:47:35.000Z

Will check it out when I get to my computer.

Answer 4 · 2021-01-18T19:02:53.000Z

https://github.com/YanaiEliyahu/AdasOptimizer/blob/master/adasopt_pytorch.py

In my own testing it works OK.
How does it work for you?

It seems like Cuda is not properly set when running this code on the GPU,
adding device="cuda:0 here made it work temporary, but it can probably be set automatically depending on input device?

Answer 5 · 2021-01-18T22:19:23.000Z

does ,device=self._curr_var.device also work for you?

Answer 6 · 2021-01-18T22:28:33.000Z

does ,device=self._curr_var.device also work for you?

Yes that seems to work

Answer 7 · 2021-01-18T22:30:00.000Z

Great, I'll close this just for the protocol.