MIDI files end up their last note pushed up a position
gstranger opened this issue · 6 comments
Hello, thank you for publishing this repo. I noticed theres a bug that occurs at the end of a MIDI file when encoding to REMI.
The very last note, or multiple notes that occur after a certain position in the last bar will be "pushed up" a position making them off rhythmically. I'm not sure how to fix this. I assume there must be an issue in the item2event function but I'm not very experienced with numpy.
Archive 2.zip
ZIP example MIDI file, and then final result that has occurrence of bug.
Hello, I have a question for you.I use the program provided by the author, but the item2event does not work. I would like to ask you how to run the code ?I hope you can inform me, I would be grateful.
When I run the conversion code, the computer comes up with a question(FileNotFoundError: [Errno 2] No such file or directory: '.\pop data').I want to know how to solve.
the item2event method doesn't take a file, you should call read_items instead.
Sorry，I do not understand read_items .But midi2remi.ipynb is not run. I want to know how you run.
I found the issue, it looks like the quantize_items method is pushing the last notes up a couple position. I'll see if I can come up with a fix and submit a PR @remyhuang